From 8122f8932236af1069ba0cfcd69fa1c5cf4864fc Mon Sep 17 00:00:00 2001
From: Petko Bordjukov <bordjukov@gmail.com>
Date: Thu, 7 Aug 2014 15:19:28 +0300
Subject: [PATCH] Add more validations to SpeakerProfile

---
 app/models/speaker_profile.rb       |  7 ++++
 spec/models/speaker_profile_spec.rb | 58 +++++++++++++++++++++++++++++
 2 files changed, 65 insertions(+)

diff --git a/app/models/speaker_profile.rb b/app/models/speaker_profile.rb
index e518374..4af25d1 100644
--- a/app/models/speaker_profile.rb
+++ b/app/models/speaker_profile.rb
@@ -6,6 +6,13 @@ class SpeakerProfile < ActiveRecord::Base
   validates :photo_url, presence: true
   validates :mobile_phone, phony_plausible: true, presence: true
   validates :biography, presence: true
+  validates :public_email, format: {with: /\A[^@]+@[^@]+\z/}, allow_blank: true
+  validates :twitter, format: {with: /\A[a-z0-9_]{1,15}\z/i}, allow_blank: true
+  validates :github, format: {with: /\A[a-z0-9][a-z0-9\-]*\z/i}, allow_blank: true
 
   phony_normalize :mobile_phone, default_country_code: 'BG'
+
+  def twitter=(handle)
+    write_attribute :twitter, handle.gsub(/\A@/,'') if handle
+  end
 end
diff --git a/spec/models/speaker_profile_spec.rb b/spec/models/speaker_profile_spec.rb
index ab4fcb5..008941d 100644
--- a/spec/models/speaker_profile_spec.rb
+++ b/spec/models/speaker_profile_spec.rb
@@ -32,6 +32,64 @@ RSpec.describe SpeakerProfile, :type => :model do
     end
   end
 
+  describe 'public email' do
+    it 'can be absent' do
+      expect(build(:speaker_profile, public_email: '')).to_not have_error_on :public_email
+    end
+
+    it 'can contain exatly one @ when present' do
+      expect(build(:speaker_profile, public_email: 'test@@example.com')).to have_error_on :public_email
+      expect(build(:speaker_profile, public_email: 'test@example.com')).to_not have_error_on :public_email
+      expect(build(:speaker_profile, public_email: 'testexample.com')).to have_error_on :public_email
+    end
+  end
+
+  describe 'twitter handle' do
+    it 'can be absent' do
+      expect(build(:speaker_profile, twitter: '')).to_not have_error_on :twitter
+    end
+
+    context 'when present' do
+      it 'is stored without a starting @' do
+        expect(create(:speaker_profile, twitter: '@foobar').twitter).to eq 'foobar'
+      end
+
+      it 'must contain only alphanumeric symbols or an underscore' do
+        speaker_profile = build :speaker_profile
+        speaker_profile.twitter = 'fooBar_1'
+        expect(speaker_profile).to_not have_error_on :twitter
+
+        speaker_profile.twitter = 'foobar!'
+        expect(speaker_profile).to have_error_on :twitter
+      end
+
+      it 'must be maximum 15 symbols long' do
+        expect(build(:speaker_profile, twitter: 'a'*16)).to have_error_on :twitter
+      end
+    end
+  end
+
+  describe 'github account' do
+    it 'can be absent' do
+      expect(build(:speaker_profile, github: '')).to_not have_error_on :twitter
+    end
+
+    context 'when present' do
+      it 'must contain only alphanumeric symbols or a dash' do
+        speaker_profile = build :speaker_profile
+        speaker_profile.github = 'fooBar-1'
+        expect(speaker_profile).to_not have_error_on :github
+
+        speaker_profile.github = 'foobar!'
+        expect(speaker_profile).to have_error_on :github
+      end
+
+      it 'must not start with a dash' do
+        expect(build(:speaker_profile, github: '-foobar')).to have_error_on :github
+      end
+    end
+  end
+
   it 'is invalid without a bio' do
     expect(build(:speaker_profile, biography: nil)).to have_error_on :biography
   end