Create conference slug and maintain it in params
This commit is contained in:
parent
6ce06ddbf6
commit
df682e65e5
|
@ -1,21 +1,13 @@
|
||||||
module Management
|
module Management
|
||||||
class CallForParticipationsController < ManagementController
|
class CallForParticipationsController < ManagementController
|
||||||
before_action :assign_conference
|
|
||||||
|
|
||||||
def create
|
def create
|
||||||
@conference.call_for_participation.open!
|
current_conference.call_for_participation.open!
|
||||||
render :redraw
|
render :redraw
|
||||||
end
|
end
|
||||||
|
|
||||||
def destroy
|
def destroy
|
||||||
@conference.call_for_participation.close!
|
current_conference.call_for_participation.close!
|
||||||
render :redraw
|
render :redraw
|
||||||
end
|
end
|
||||||
|
|
||||||
private
|
|
||||||
|
|
||||||
def assign_conference
|
|
||||||
@conference = Conference.find params[:conference_id]
|
|
||||||
end
|
|
||||||
end
|
end
|
||||||
end
|
end
|
||||||
|
|
|
@ -10,8 +10,7 @@ module Management
|
||||||
@conference = Conference.new(conference_params)
|
@conference = Conference.new(conference_params)
|
||||||
|
|
||||||
if @conference.save
|
if @conference.save
|
||||||
set_current_conference(@conference)
|
redirect_to management_conference_path(@conference, current_conference: @conference.slug)
|
||||||
redirect_to [:management, @conference]
|
|
||||||
else
|
else
|
||||||
render :new
|
render :new
|
||||||
end
|
end
|
||||||
|
@ -39,9 +38,8 @@ module Management
|
||||||
def destroy
|
def destroy
|
||||||
@conference = find_conference
|
@conference = find_conference
|
||||||
@conference.destroy
|
@conference.destroy
|
||||||
set_current_conference(nil)
|
|
||||||
|
|
||||||
redirect_to management_root_path
|
redirect_to management_root_path(current_conference: nil)
|
||||||
end
|
end
|
||||||
|
|
||||||
private
|
private
|
||||||
|
|
|
@ -5,9 +5,7 @@ module Management
|
||||||
|
|
||||||
def set_conference
|
def set_conference
|
||||||
conference = Conference.find(params[:id])
|
conference = Conference.find(params[:id])
|
||||||
set_current_conference(conference)
|
redirect_to management_conference_path(conference, current_conference: conference.slug)
|
||||||
|
|
||||||
redirect_to [:management, conference]
|
|
||||||
end
|
end
|
||||||
end
|
end
|
||||||
end
|
end
|
||||||
|
|
|
@ -15,29 +15,16 @@ module Management
|
||||||
end
|
end
|
||||||
helper_method :current_conference?
|
helper_method :current_conference?
|
||||||
|
|
||||||
# TODO (2015-06-09) Fetch conferences by slug only
|
|
||||||
def current_conference
|
def current_conference
|
||||||
@current_conference ||=
|
@current_conference ||=
|
||||||
begin
|
begin
|
||||||
# if params[:current_conference]
|
if params[:current_conference]
|
||||||
# Conference.find_by_slug(params[:current_conference])
|
Conference.find_by_slug(params[:current_conference])
|
||||||
# end
|
|
||||||
|
|
||||||
if session[:current_conference_id]
|
|
||||||
Conference.find_by(id: session[:current_conference_id])
|
|
||||||
end
|
end
|
||||||
end
|
end
|
||||||
end
|
end
|
||||||
helper_method :current_conference
|
helper_method :current_conference
|
||||||
|
|
||||||
def set_current_conference(conference)
|
|
||||||
if conference.present?
|
|
||||||
session[:current_conference_id] = conference.id
|
|
||||||
else
|
|
||||||
session.delete(:current_conference_id)
|
|
||||||
end
|
|
||||||
end
|
|
||||||
|
|
||||||
def authorize_user!
|
def authorize_user!
|
||||||
head :forbidden unless current_user.admin?
|
head :forbidden unless current_user.admin?
|
||||||
end
|
end
|
||||||
|
|
|
@ -16,6 +16,7 @@ class Conference < ActiveRecord::Base
|
||||||
|
|
||||||
accepts_nested_attributes_for :tracks, :halls, reject_if: :all_blank, allow_destroy: true
|
accepts_nested_attributes_for :tracks, :halls, reject_if: :all_blank, allow_destroy: true
|
||||||
|
|
||||||
|
before_create :slugify_title
|
||||||
after_create :create_call_for_participation
|
after_create :create_call_for_participation
|
||||||
|
|
||||||
def submissions_grouped_by_day
|
def submissions_grouped_by_day
|
||||||
|
@ -28,15 +29,13 @@ class Conference < ActiveRecord::Base
|
||||||
submissions.group_by { |s| s.confirmed_at.to_date }
|
submissions.group_by { |s| s.confirmed_at.to_date }
|
||||||
end
|
end
|
||||||
|
|
||||||
def slug
|
def self.find_by_slug(slug)
|
||||||
title.gsub(' ', '-')
|
find_by(slug: slug)
|
||||||
end
|
end
|
||||||
|
|
||||||
# TODO (2015-06-09) Stupid and temporary, put slug in db
|
def slugify_title
|
||||||
# TODO (2015-06-09) Also, doesn't work due to translations?
|
self.slug = title.gsub(/\s+/, '-')
|
||||||
# def self.find_by_slug(slug)
|
end
|
||||||
# find_by(title: slug.to_s.gsub('-', ' '))
|
|
||||||
# end
|
|
||||||
|
|
||||||
private
|
private
|
||||||
|
|
||||||
|
|
|
@ -0,0 +1,6 @@
|
||||||
|
class AddSlugToConferences < ActiveRecord::Migration
|
||||||
|
def change
|
||||||
|
add_column :conferences, :slug, :string
|
||||||
|
add_index :conferences, :slug
|
||||||
|
end
|
||||||
|
end
|
|
@ -0,0 +1,13 @@
|
||||||
|
class CreateSlugsForExistingConferences < ActiveRecord::Migration
|
||||||
|
class Conference < ActiveRecord::Base
|
||||||
|
end
|
||||||
|
|
||||||
|
def change
|
||||||
|
Globalize.with_locale(:en) do
|
||||||
|
Conference.find_each do |c|
|
||||||
|
c.slug = c.title.gsub(/\s+/, '-')
|
||||||
|
c.save!
|
||||||
|
end
|
||||||
|
end
|
||||||
|
end
|
||||||
|
end
|
|
@ -8,7 +8,7 @@ RSpec.describe Management::CallForParticipationsController, type: :controller do
|
||||||
describe 'POST #create' do
|
describe 'POST #create' do
|
||||||
it 'opens the CFP of the specified conference' do
|
it 'opens the CFP of the specified conference' do
|
||||||
expect do
|
expect do
|
||||||
post 'create', conference_id: conference.id, format: :js
|
post 'create', current_conference: conference.slug, format: :js
|
||||||
end.to change { Conference.find(conference.id).call_for_participation.in_progress? }.from(false).to(true)
|
end.to change { Conference.find(conference.id).call_for_participation.in_progress? }.from(false).to(true)
|
||||||
end
|
end
|
||||||
end
|
end
|
||||||
|
@ -18,7 +18,7 @@ RSpec.describe Management::CallForParticipationsController, type: :controller do
|
||||||
conference.call_for_participation.open!
|
conference.call_for_participation.open!
|
||||||
|
|
||||||
expect do
|
expect do
|
||||||
delete 'destroy', conference_id: conference.id, format: :js
|
delete 'destroy', current_conference: conference.slug, format: :js
|
||||||
end.to change { Conference.find(conference.id).call_for_participation.in_progress? }.from(true).to(false)
|
end.to change { Conference.find(conference.id).call_for_participation.in_progress? }.from(true).to(false)
|
||||||
end
|
end
|
||||||
end
|
end
|
||||||
|
|
|
@ -2,7 +2,7 @@
|
||||||
|
|
||||||
FactoryGirl.define do
|
FactoryGirl.define do
|
||||||
factory :conference do
|
factory :conference do
|
||||||
title { |n| "Conference-#{n}" }
|
sequence(:title) { |n| "Conference-#{n}" }
|
||||||
email
|
email
|
||||||
description 'MyText'
|
description 'MyText'
|
||||||
start_date '2014-07-29 21:29:13'
|
start_date '2014-07-29 21:29:13'
|
||||||
|
|
Loading…
Reference in New Issue